Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
58 stars 47 forks source link

Feature Request: @PartyAdd #1054

Closed DavideRei closed 11 months ago

DavideRei commented 1 year ago

Could be useful a trigger that fires when a member is added to a party. For example to add some effect on party members, like an aura, always active on party members.

DavideRei commented 1 year ago

thank you, it works but i think i found a bug. If you invite 2 player to your party, with the context menu, before the party exists, and the second player accept the invite, the first invite is canceled but the player can still accept and he join a phantom party.

image

Another request: is it possible to invite player with the context menu even if the party already exists? right now you can invite with the context menu only the first member, but it would be convenient to invite other members with the context menu.

xwerswoodx commented 1 year ago

The problem is, this party context menu totally client-side. What I mean is we can't change it's design, because it's not designed in Server. The buttons automatically removed from the context when you join the party, for the invites, you can join parties after 1st player joined so it's expected behaviour. I didn't get what do you mean with second one cancelled because invites should never cancel. (Except timeout maybe, I am not sure if invites has any timeout)

DavideRei commented 1 year ago

The problem is that the player who accepts the invitation last, doesn't join the party where he was invited. The party system for that player become broken. As you can see in the screenshot, the "leave the party" button is visible (as if he were in a group) with no party members. .xshow party or .xshow isinparty return 0 and the player can't accepts further invitations. He can only logout to fix the problem.

About the context menu, isn't Sphere telling the client what entries to show in the menu? The context menu is customizable by scripts

xwerswoodx commented 1 year ago

I see, but I am testing on latest client and sphere, I have no issue about it, it probably client-side issue, or I don't know but seems like you only can invite 1 player to party same time, when you invite second person, it cancels automatically, and when I accept it says no invite for me. Even I joined party for 3 people still can see them in party without any issue. Probably the client you use doesn't parse it correctly, Because some uo clients can be broken on this system, or maybe some flags affect it but I am not sure if there is any flag to do it.