search

Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
58 stars 47 forks source link

Add some item props functionnality #1131

Closed Jhobean closed 8 months ago

Jhobean commented 1 year ago

I have 3 bug on this version.

1- (EDIT: FIXED) Line (pCharTarg->GetPropNum(pCCPChar, PROPCH_REFLECTPHYSICALDAM, pBaseCCPChar)) always return 0... I set REFLECTPHYSICALDAM on target but dont know why always 0

2- (EDIT: I added LOS and range 5 to 10 depending of ERA) is the damage area function. I copy pasted from 56d but after testing it it's just fucking non sense. I hit everyone on the BIG screen including NPC,PET inside or outside house lol

3- (EDIT: I choose 3 type of damage link to physical) How I can use only physical damage on iDmg ?

drk84 commented 1 year ago

2)Take a look at the Spell_Area method, anyway this area damage properties should call onTakeDamage, don't make a new method onTakeDamageArea 3)The damage applied is based upon the utype flag

Jhobean commented 1 year ago

Seem OK on my side. The only thing i'm not sure is the Area damage hitting everyone.

Should I remove own pet? Should I remove all criminal action? How?

image

Jhobean commented 1 year ago

@drk84 I don't figure how avoid a new method for Takedamagearea...

Yes I use takeDamage on the new method.

What you think of this commit?

cbnolok commented 1 year ago

Did you figure out the last prop you were working on? Is it still a draft?

Jhobean commented 1 year ago

Did you figure out the last prop you were working on? Is it still a draft?

Ready to merge. I fixed the "criminal act check" if (pChar->Noto_CalcFlag(pSrc) == NOTO_GOOD)

cbnolok commented 8 months ago

Could you please fix the conflicts, in order to merge?