Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
57 stars 45 forks source link

[Feature Proposal] Separation of Sphere.ini Event definitions #1141

Open canerksk opened 11 months ago

canerksk commented 11 months ago

m_sEventsItem m_sEventsPet m_sEventsPlayer

In addition to these definitions;

m_sEventsChar <-- All Chars m_sEventsItem <-- Only Items m_sEventsNPC <-- Only NPC Chars m_sEventsPlayer <-- Only Player Chars m_sEventsStaff <-- Only Staff Chars

Event separations can be made easier by adding

Why do we want this?

There is only the m_sEventsPlayer definition here, and we have to perform additional operations when we want to give an event for all authorized characters or NPCs.

The codes here are purely examples. Although many have been tested, some may need to be rewritten.

Soulless-1 commented 2 weeks ago

I agree with this thought, with minor suggestions to make it more fine tuned:

m_sEventsItem <-- Only Items m_sEventsChar <-- All Chars m_sEventsNPC <-- Only NPC Chars m_sEventsPet <-- Only Pets m_sEventsPlayer <-- Only Player Chars m_sEventsStaff <-- Only Staff Chars