search

Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
57 stars 45 forks source link

[Bug (Maybe)] Kill Increase When a Criminal Kills #1160

Closed canerksk closed 10 months ago

canerksk commented 11 months ago

In the past, +kill was not earned when a criminal was killed.

eg fix;

old:

    else if ( NotoThem != NOTO_GUILD_SAME )
    {
        // I'm a murderer !

new:

    else if ( NotoThem < NOTO_NEUTRAL && NotoThem != NOTO_GUILD_SAME )
    {
        // I'm a murderer !

The codes here are purely examples. Although many have been tested, some may need to be rewritten.

cbnolok commented 11 months ago

Maybe a ini setting would be good here to edit default behavior, and an override in a trigger could be useful

Soulless-1 commented 11 months ago

If criminals are giving kill counts that's definitely a bug, we should probably fix that without a trigger. if someone wants to give someone a kill count for killing criminals (which is not normal) they could easily do that in the scripts. but that sort of thing is the opposite of how it should work. You only receive a kill count for killing innocent targets.

On=@death
if (<flags>&statf_criminal)
  for n 0 <eval (<attacker>-1)>
    kills += 1
  endfor  
endif
raydienull commented 10 months ago

Here i think we have a "little problem" In the original UO content. Kills are only earned if the killed mark the murder count

https://uo.com/wiki/ultima-online-wiki/player/the-murder-system/

but in the website say If the victim dies before the criminal flag timer ends, the attacker is guilty of murder, regardless of whether he actually administered the killing blow. This includes damage inflicted by pets or summons.

so criminal kills dont earn kills

raydienull commented 10 months ago

Closed, this work fine. Maybe implement the feature of Report murder system