search

Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
57 stars 45 forks source link

[Bug (Maybe)] Should the cursor return to normal after death? #1172

Closed canerksk closed 5 months ago

canerksk commented 11 months ago

If the cursor does not close after death, we may invite many things, otherwise we may need to ask whether the cursor is dead or not under each targeting query. This can also be optionally added as a death trigger argument or INCLUDED IN DEATHFLAGS.

for example;

DEATH_CLOSECURSOR 0x020

if ((m_TagDefs.GetKeyNum("DEATHFLAGS") & DEATH_CLOSECURSOR ))
pClient->addTargetCancel();
raydienull commented 10 months ago

Not need to have DEATH_CLOSECURSOR because is normal behaviour that cancel target when character death

DavideRei commented 10 months ago

In ClassicUO they did a commit to not close the target on character death, because it's OSI default behavior, they say

cbnolok commented 10 months ago

So, are there clients where the target is not cancelled on death?

DavideRei commented 10 months ago

Yes https://github.com/ClassicUO/ClassicUO/commit/fd7bede01e6fd3959aa422bf6870b179b8e7e5c6

canerksk commented 10 months ago

Maybe some servers may want to take action after deathflags to use additional systems, so I thought it would be better to connect it to a deathflag.

eg; her may want to enable the character to revive herself with a special bandage.