search

Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
57 stars 45 forks source link

Fix Attack stop #684 #1200

Open raydienull opened 9 months ago

raydienull commented 9 months ago

Fix for make player still attacking when dont have skill active but s…tay on war and have Fight target

Close #684

GladieUO commented 2 months ago

I think this one can be pushed too, if agreed by devs, no?

Tolokio commented 1 month ago

I dont want to stop the pull or disturb anyone but I need to understand this and u know how I am... I can't test with this pc, sorry if I dont find answer by myself.

Does this affect to any skill or just magery? For example, healing yourself also stop you from attacking? I see noone saying "bandages stop combat"

image

Following drk's logic it should stop attacking.

I dont like the fix cos if I leave my player just doing nothing or just walking around, that check will be firing once per second (not too much but we could avoid it doing it only when neccesary. If it is related just to magery, we can do it just when magery ends. And if it only related to magery that means there is a bug somewhere and this is not a real fix cos bug is not solved.

If it is happening with any skill as drk84 suggest. We can put the fix when a skill is done or when action is changed to: "skill_none". No reason to let this fix be firing again and again once per second. I repeat is it not too much but you know.... "performance"...

If we are sure this is the best option for me is fine.

image Maybe here?