Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
57 stars 45 forks source link

Follower Commands Don't Work. #1215

Closed Nefrelius closed 1 month ago

Nefrelius commented 7 months ago

There is no need to elaborate on the problem here. We know that there are commands for followers such as kill, come, stay and these are heard by the follower closest to us. But when the player types ALL , all the followers around him should obey the command. But there is no such thing :) Even if you type Kill or All Kill, only the follower closest to you hears the command. BUT! The player once typed ALL KILL and the closest follower attacked. Then if the player types ALL KILL again, all followers attack. I think there is a small query error.

[translate DeepL]

xwerswoodx commented 6 months ago

It looks like working for me , I spawn 5-6 horses around and when I type ALL KILL all of them start attacking, are you sure it's not a script-side bug? Could you reproduce it with an clean sphere?

Soulless-1 commented 6 months ago

i tried it also myself. as non gm, surrounded by many untamed animals and my tamed animals. they did attack the target image

in the past though i did report some issues, and i believe they were resolved, at least it appears that way as of current.

GladieUO commented 6 months ago

I remember one of the issues was it worked only for the first time, try to change target with all kill from one to second and back. They didnt follow.

DavideRei commented 6 months ago

There is a bug in CChar::NPC_Act_Follow, it the pet follow his master, it uses m_Act_UID else it uses m_Fight_Targ_UID even if the pet is not in combat! I can fix this but i don't know if is related

xwerswoodx commented 5 months ago

I tried again with the info you gave, I used all kill, attacked all npcs to the one target, then used all come and they start following me, used that way many times even tried to change all kill target, they always listen what I told and changed their target, even stop and following me etc, but all command range looks a bit small maybe this makes player to think it doesn't working, I will check the range

There is a setting in sphere.ini for it, it's 4 in default, but you can increase this to 10-15 to make npcs listen you further away. It was 14 in 56b, I have no idea why someone changed it to 4, it's totally meaningless NPCDistanceHear=4

GladieUO commented 5 months ago

Thats is great to hear!!! I will comment my custom commands and try it again! Also "All guard me" should work too right? automatically attacking what im attacking.

xwerswoodx commented 5 months ago

Yes, I tested all guard me and it works fine too, as soon as I tried to attack, every npcs around me start attacking it