search

Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
53 stars 40 forks source link

TEVENTS not being saved on the item #1235

Closed AtillaG1 closed 2 months ago

AtillaG1 commented 2 months ago
  1. build house (multi)
  2. on the brass sign, it will add (ei_house_sign), which is dialog for housing. (added to the sign via itemdef)
  3. save sphere
  4. reboot sphere
  5. check brass sign
  6. TEVENT is no longer there

Changing TEVENT to EVENT, it will save it fine.

xwerswoodx commented 2 months ago

It's working fine for me, are you sure you are using correct command to check? You need to use .xshow TEVENTS to check TEVENTS?

AtillaG1 commented 2 months ago

There is dialog being called on @dclick, but after reboot there is no dialog because there is no TEVENT. image

BEFORE REBOOT image AFTER REBOOT image

ALSO NOT BEING SAVED IN SAVE (ignore the EVENT - this is just temporary fix for me) image

xwerswoodx commented 2 months ago

It still looking fine for me, I created house, turned it to customizable house,

Before Restart: image After Restart: image

xwerswoodx commented 2 months ago

Could you try it with this build;

https://github.com/Sphereserver/Source-X/actions/runs/8680991381

maybe it was fixed, while I am fixing another things.

AtillaG1 commented 2 months ago

Hmm didnt help. I wonder what can cause this on script side. Doesnt make sense to me.

xwerswoodx commented 2 months ago

TEVENTS doesn't saved on save files, it will reload from itemdef when you start the server, are you sure you haven't changed TEVENTS before restarting your server? Or using different sign?

AtillaG1 commented 2 months ago

Ok, got it. For some reason I had defname=i_sign_brass for 3 different signs. Even tho they are custom itemdefs with ID of original. Thanks for help!

cbnolok commented 2 months ago

Ok, got it. For some reason I had defname=i_sign_brass for 3 different signs. Even tho they are custom itemdefs with ID of original. Thanks for help!

Didn't you get a console error for that?

AtillaG1 commented 2 months ago

Nope, I think its because the items are scripted fine, only has same defnames, which for custom items work like alternative name or something, not sure 100%.

AtillaG1 commented 2 months ago

image

Jhobean commented 2 months ago

Normaly on boot you should have a warning like "redefining i_sign_brass"

cbnolok commented 2 months ago

I think you get that error message only when setting a defname as an argument to the itemdef section header, i feel we should add a warning also when overwriting with a duplicate defname inside the section itself