search

Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
57 stars 45 forks source link

@PersonalSpace trigger malfunctioning #1250

Open GladieUO opened 3 months ago

GladieUO commented 3 months ago

https://wiki.spherecommunity.net/index.php?title=@PersonalSpace Basically it will allow stepper step over you only once with full stam, than he get blocked, untill you set ARGN1 to 0 and create your own stamina drain.

ARGN2 - doesnt do anything so setting it to 1 or 0 does non

This is basically how I had to do it to allow players step over NPCs and drain some stamina

ON=@PersonalSpace IF () IF ( > 10) SRC.STAM -=10 ARGN1=0 ENDIF ENDIF

Jhobean commented 3 months ago

What version of sphere you used? This was touched on last commit https://github.com/Sphereserver/Source-X/commit/cad5459e2626ec51351342021797febce9c8d0b1#diff-e1ae3608ed3c89cae2f5c81d003b6a1eb1b38b9313e6ccae97fd96b106c27e6e

GladieUO commented 3 months ago

What version of sphere you used? This was touched on last commit cad5459#diff-e1ae3608ed3c89cae2f5c81d003b6a1eb1b38b9313e6ccae97fd96b106c27e6e

Compiled at Jun 14 2024 (21:17:53) [branch master / build 3752 / GIT hash 8e444840f7e916126f5f4c1a56b4049e34b20fbd]

Tolokio commented 3 months ago

image

Right now, the lane marked in red causes any attempt to fail if stam is lesser than maxstam. This means any custom script will need to do what u did. Set argn=0 to always allow step and then use your own system to allow or deny. If argn is not set 0, only chars at maxstam will step.

Can be changed, but I see no real drama to let it be as it is cos u can set ur own custom system. But I can agree it is confusing.

Jhobean commented 2 months ago

Could you try to set this to 1 and test again? image

GladieUO commented 2 months ago

Could you try to set this to 1 and test again?

Im using this setting already

Tolokio commented 2 months ago

we should add a local.AllowifStamIsLowerThanMaxStam or another sphere.ini config for it. Whatever u decide I can try.

GladieUO commented 2 months ago

we should add a local.AllowifStamIsLowerThanMaxStam or another sphere.ini config for it. Whatever u decide I can try.

I cant make that decision, thats up to devs. I only know that we can make workaround, but the trigger is useless as it is now. Without argn1=0 you cant do anything, and still argn2 doesnt do anything either way. 😶

Tolokio commented 2 months ago

the trigger is not useless but I agree with you that there should be a way to bypass that behaviour. I think a local.bypassStam should do the job. Whatever U (the community) decide I can try.

MAybe we could remove the check I marked in red, and include that check on the sphere-x scriptpack instead source.