Sphereserver / Source-X

Ultima Online server emulator
Apache License 2.0
53 stars 40 forks source link

ON=@FollowersUpdate not working as intended? #1251

Open AtillaG1 opened 1 week ago

AtillaG1 commented 1 week ago

Added @FollowersUpdate trigger called in any update of followers related to OF_PetSlots: argn1 (R/W): 0 = Adding followers (taming, unshrinking, summoning, buying ...), 1 = sustracting followers (release, transfer ...) argn2 (R/W): FollowerSlots used. SRC: Pet causing the trigger to run, when buying in vendors there's no PET yet, so SRC will point to the vendor. Return 1 will not allow following actions to occur: Transfer, Summon, UnShrinks from t_figurine, Buy from vendors. Any other actions (like release, set owner...) will not take in count returns.

Im using EF_FollowerList and OF_PetSlots. Im trying to use my own followerslots, since the default behaviour is not using more than 1. Somehow, even tho i set ARGN2 to whatever amount, there is always only 1 slot used.

Is this suppose to be still linked to the maxfollowers and curfollowers, and slots? I feel like its working like half a way 😥

AtillaG1 commented 1 week ago

https://github.com/Sphereserver/Source-X/blob/8e444840f7e916126f5f4c1a56b4049e34b20fbd/src/game/chars/CCharUse.cpp#L1172

It will add correct follower slots only if EF_FollowerList is disabled.

DavideRei commented 1 week ago

I think the new system work in a partial way, it should take into consideration the follower slots.