Server crash when cast Magic Reflection

Sphereserver / Source-X

Ultima Online server emulator

Apache License 2.0

57 stars 45 forks source link

Server crash when cast Magic Reflection #400

Closed alexdan2 closed 4 years ago

alexdan2 commented 4 years ago

Hello, when cast this spell server crash.

Spell definition: [SPELL 36] DEFNAME=s_magic_reflection NAME=Magic Reflection SOUND=snd_spell_magic_reflection RUNES=IJS CAST_TIME=3.0 RESOURCES=i_reag_garlic,i_reag_mandrake_root,i_reag_spider_silk RUNE_ITEM=i_rune_magic_reflection SCROLL_ITEM=i_scroll_magic_reflection FLAGS=spellflag_dir_anim|spellflag_targ_char|spellflag_fx_targ|spellflag_good|spellflag_bless EFFECT_ID=i_fx_bless_effect EFFECT=0 LAYER=layer_spell_magic_reflect DURATION=60.0,2*60.0 MANAUSE=14 SKILLREQ=MAGERY 50.0 INTERRUPT=100.0,100.0 PROMPT_MSG=Who shall you protect?

Additional info:

How try use simple .cast s_magic_reflection in game
Server simple close no trace of any error in logs file
Try on different version build (X64) 3257 (last) and old one same issue Thx

GitMadKing commented 4 years ago

did not happen to me [win-x64] Compiled at Apr 3 2020 (17:48:03) [build 3255 / GIT hash f008c5c2fbb86ee1365f1c9cb6874a4cc754f37b] neither [win-x64] Compiled at Apr 5 2020 (21:27:47) [build 3257 / GIT hash 01a081bcfdc41a85b243d51aae6d396c4e0f8ffc]

alexdan2 commented 4 years ago

I'm using https://forum.spherecommunity.net/sshare.php?srt=4 clear script pack for test and happen also.

Possible some different in INI ?

Additional Info: i try also whit MagicFlags=0 .. but same issue

GitMadKing commented 4 years ago

also me magicflags=0 clean scripts try clean sphere.ini

pentanorl commented 4 years ago

it seems that both "s_magic_reflection" and "s_curse" cause crash only when casted on players on @spelleffect. On npcs they work as supposed to (at lease magic reflection, curse seems to do nothing).

alexdan2 commented 4 years ago

Is is a ini flag. Coming details...

pentanorl commented 4 years ago

Looks like the OptionFlag "OF_Buffs" conflicts with the CombatFlag "COMBAT_ELEMENTAL_ENGINE". Disabling one or the other solves it.

alexdan2 commented 4 years ago

yes @pentanorl. I can confirm if enable OF_Buffs and COMBAT_ELEMENTAL_ENGINE server crash when cast on a player.

alexdan2 commented 4 years ago

Just tested on Build 3262. Fix working good. No longer crash when cast s_magic_reflection and s_curse on Playerm whit both flags enabled