search

SpiGetOrg / Spiget

Spiget Issue tracker
Apache License 2.0
11 stars 2 forks source link

Some Resource get URLS return HTML webpage instead of valid .jar plugin file #45

Closed bjornpijnacker closed 2 years ago

bjornpijnacker commented 2 years ago

As the title names, some get requests to https://api.spiget.org/v2/resources/{plugin_id}/download return the HTML download page for the plugin instead of the plugin's .jar file. Example IDs for which this occurs is 9089 (EssentialsX) and 274 (DynMap).

InventivetalentDev commented 2 years ago

both of those resources are hosted on external sites, hence the broken download. see #20 #27

Th3Shadowbroker commented 2 years ago

Hey there, I were able to replicate the described behaviour. However both of the plugins you've named link to an external download page or at least their current version does. As these pages vary for each plugin, individual web-crawling is impossible. I've checked the request via postman and SpiGet responds with a 302 - Found. I think, that such a response should be handled on the client side as the API response matches its documentation.

EDIT: Didn't saw the reply until GitHub reloaded when posting the comment 😄