search

SpiNNakerManchester / PACMAN

Partition and Configuration Manager for SpiNNaker
Apache License 2.0
9 stars 7 forks source link

FixedKeyAndMaskConstraint limit to a single BaseKeyAndMask #438

Closed Christian-B closed 2 years ago

Christian-B commented 2 years ago

For some reason FixedKeyAndMaskConstraint Inputs and outputs an iterable of BaseKeyAndMask

yet all known use case take just 1.

Does it even makes sense for there to be multiple FIXED KeysandMasks on one partition?

Suggest we change it to only accept 1 BaseKeyAndMask

Christian-B commented 2 years ago

This would also avoid the ugly and incorrect eg and hash functions!

Christian-B commented 2 years ago

@rowleya commented on skype "Yes, happy to drop to 1 key and mask"

Christian-B commented 2 years ago

https://github.com/SpiNNakerManchester/PACMAN/pull/463 removes the whole FixedKeyAndMaskConstraint which of course makes this issue no longer exists

Christian-B commented 2 years ago

Done by https://github.com/SpiNNakerManchester/PACMAN/pull/464