search

SpiNNakerManchester / PACMAN

Partition and Configuration Manager for SpiNNaker
Apache License 2.0
9 stars 7 forks source link

Global hard rest required and requires_data_generation #448

Closed Christian-B closed 2 years ago

Christian-B commented 2 years ago

Currently there are many places where the need for a hard reset or data generation is recorded.

This includes: in the View in AbstractChangableAfterRun vertices and partitions

as the rule is if a single one says yes, the answer is yes why not just save these in the View Anything that detects a change sets the flag in the View

Christian-B commented 2 years ago

Looking at requires_mapping 2 case found where is is only set at init True at init so not needed: Projection SpinnGymApplicationVertex

Christian-B commented 2 years ago

Population _internal_delay_vertex appears unused so suggest removing the methods and delay_vertex param,

Christian-B commented 2 years ago

To the best of my knowledge all Splitters except the SplitterDelayVertexSlice use app_vertex.get_max_atoms_per_core() to determine their partition slices. app_vertex.get_max_atoms_per_core() is only implemented in ApplicationVertex. The only thing that changes the max value is the setter which is only called by the script via the Population

SplitterDelayVertexSlice gets slices from its source so see above.

Therefor the ONLY change that affect partitioning is Population.set_max_atoms_per_core

Christian-B commented 2 years ago

the calls know to affect placements are Population set_constraint, add_placement_constraint and set_mapping_constraint

Christian-B commented 2 years ago

fixed by https://github.com/SpiNNakerManchester/PACMAN/pull/462