SpiNNakerManchester / PACMAN

Partition and Configuration Manager for SpiNNaker
Apache License 2.0
9 stars 7 forks source link

Create graph #450

Closed Christian-B closed 2 years ago

Christian-B commented 2 years ago

Builds on https://github.com/SpiNNakerManchester/PACMAN/pull/449

An ApplicationGraph is now created during the Writer.setup or mock call. So except for before sim.setup (or unittestsetup()) there is always a graph so no need to call create graph or set(runtime)_ graph

The Graph Class (or at least what was actually needed) has been merged into ApplicationGraph. With the following changes

As the Graph is never cloned the clone method has been removed.

As the Graph is never given to the use the ApplicationGraphView is no longer need

Must be done after: https://github.com/SpiNNakerManchester/SpiNNUtils/pull/184

Must be done at the same time as: https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/961 https://github.com/SpiNNakerManchester/sPyNNaker/pull/1202 https://github.com/SpiNNakerManchester/SpiNNakerGraphFrontEnd/pull/217

tested by http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/create_graph/3/pipeline

Documented by https://github.com/SpiNNakerManchester/SpiNNakerManchester.github.io/pull/42