search

SpiNNakerManchester / PACMAN

Partition and Configuration Manager for SpiNNaker
Apache License 2.0
9 stars 7 forks source link

Auto detection of LegacyPartitionerAPI never worked #457

Closed Christian-B closed 2 years ago

Christian-B commented 2 years ago

There is a mistake in the LegacyPartitionerAPI detection.

The api defines: @abstractproperty def n_atoms(self):

Which is the same as ApplicationVertex has.

Yet the test class DuckLegacyApplicationVertex has it without the @property tag

If you add the property tag you get: pacman.exceptions.PacmanConfigurationException: The vertex ... cannot be supported by the ... as the vertex does not support the required method n_atoms of LegacyPartitionerAPI. Please inherit from the class in pacman.model.partitioner_interfaces.legacy_partitioner_api and try again.

But if you dont add the property any call to vertex.n_atoms returns a method which is not what is needed.

Clearly the auotdetection of LegacyPartitionerAPI was never used so I suggested striping that code out.

Christian-B commented 2 years ago

@rowleya says on skype: "Yes, I don't think anything is legacy any more, so happy to have it removed"