Closed Christian-B closed 2 years ago
For example SplitterOneToOneLegacy can not be While SplitterFixedLegacy
Also the way Splitters name missing name is constant.
The best is: if splitter_name is None: splitter_name = type(self).name
Many other have a splitter name which is nearly always the Class name as Constant.
My suggestion is to move the name based on Type into the base Splitter and remove the if None check elsewhere
For example SplitterOneToOneLegacy can not be While SplitterFixedLegacy
Also the way Splitters name missing name is constant.
The best is: if splitter_name is None: splitter_name = type(self).name
Many other have a splitter name which is nearly always the Class name as Constant.
My suggestion is to move the name based on Type into the base Splitter and remove the if None check elsewhere