search

SpiNNakerManchester / PACMAN

Partition and Configuration Manager for SpiNNaker
Apache License 2.0
9 stars 7 forks source link

Remove ElementAllocatorAlgorithm and KeySpaceTracker after reduce_overhead_data_spec #465

Open Christian-B opened 2 years ago

Christian-B commented 2 years ago

is there any reason to have a separate ElementAllocatorAlgorithm when its only use is as a parent to KeySpaceTracker

if you agree it can be merged assign to me.

rowleya commented 2 years ago

Happy for it to be merged. At the lastest check, in reduce_overhead_data_spec, that class is unused.

Christian-B commented 2 years ago

Only use of KeySpaceTracker in master was SynapticMatrices.

Agreed https://github.com/SpiNNakerManchester/sPyNNaker/blob/reduce_overhead_data_spec/spynnaker/pyNN/models/neuron/synaptic_matrices.py no longer uses it.

My suggestion is in that branch remove both the KeySpaceTracker and the ElementAllocatorAlgorithm rather than wasting time merging them.

rowleya commented 2 years ago

Agreed. I will remove from the branch. There is no PACMAN branch there so that can be removed separately later (so probably leave this open until then).