SpiNNakerManchester / PACMAN

Partition and Configuration Manager for SpiNNaker
Apache License 2.0
9 stars 7 forks source link

Increase coverage and some minor fixes. #467

Closed Christian-B closed 2 years ago

Christian-B commented 2 years ago

Code changes:

AbstractSingleSourcePartition.add_edge do check before changing state

ApplicationGraph add_edge: do check before changing state: add_outgoing_edge_partition: now private and all safety checks removed get_edges_starting_at_vertex: removed as unused

ApplicationFPGAVertex.incoming_fpga_connection now yields nothing rather than raise a weird exception if no connections

ConstrainedObject removed check for None as isinstance fails on None

ConstantSDRAMMachinePartition.get_sdram_size_of_region_for simplified to use known value

DestinationSegmentedSDRAMMachinePartition. raise exception rather than return None for don't know

SourceSegmentedSDRAMMachinePartition. do check before changing state add_edge @sdram_base_address.setter

SplitterExternalDevice.set_governed_app_vertex Removed if as always True on a generator

SplitterOneToOneLegacy.set_governed_app_vertex do check before changing state

MultiRegionSDRAM.nest bug fix for other types

ReverseIPtagResource eq: bug fix for other types

merged_routing_table_generator

RoutingTree removed a setter fixed type in docs

Added lots of unittests

Some of the code not tested will be remove in or with https://github.com/SpiNNakerManchester/PACMAN/issues/460 https://github.com/SpiNNakerManchester/PACMAN/issues/465 https://github.com/SpiNNakerManchester/PACMAN/pull/464

tested by: https://github.com/SpiNNakerManchester/IntegrationTests/pull/141 (note other prs tested there can be merged individually)