SpiNNakerManchester / PACMAN

Partition and Configuration Manager for SpiNNaker
Apache License 2.0
9 stars 7 forks source link

convert 1D shape into largest perfect md shape possible #514

Closed Christian-B closed 11 months ago

Christian-B commented 1 year ago

Simplest version uses a m D shape with all sides the same size.

So 256 in 3D would be (6,6,6) where a shape of (7,6,6) would be possible

andrewgait commented 1 year ago

Though perhaps a test could also be added using the script at http://spinnakermanchester.github.io/development/2d_convolutions.html

Christian-B commented 1 year ago

This is only one of several options.

Another is to keep as master and require the setting of max atoms.

Another is to have 2D defaults

andrewgait commented 1 year ago

I don't know how this was resolved so leaving it open and re-assigning it.

coveralls commented 1 year ago

Coverage Status

coverage: 83.951% (+0.3%) from 83.65% when pulling 3ee989d9fe30ec769a2087327e01a19e175a771e on md_default into b9c1c424757267b258dc63d4a3423db1303c368a on master.

Christian-B commented 11 months ago

Assume this is no longer needed.

rowleya commented 11 months ago

Yes, I think this was a test on the path, but is now no longer needed.