search

SpiNNakerManchester / SpiNNFrontEndCommon

Common support code for user-facing front end systems.
Apache License 2.0
12 stars 11 forks source link

Live vs time callback #1114

Closed Christian-B closed 1 year ago

Christian-B commented 1 year ago

https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/1116 is a simpler alternative

The LiveEventConnection has two different even callback methods.

They take different parameters and without this PR this works by usage not by implementation

Based on idea from https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/1062

But not depending on the caller happening to know that an extra parameter has been added.

Must be done at the same time as: https://github.com/SpiNNakerManchester/sPyNNaker/pull/1388 https://github.com/SpiNNakerManchester/SpiNNGym/pull/83 https://github.com/SpiNNakerManchester/Visualiser/pull/26 https://github.com/SpiNNakerManchester/PyNN8Examples/pull/109 https://github.com/SpiNNakerManchester/sPyNNakerVisualisers/pull/40 https://github.com/SpiNNakerManchester/SpiNNakerGraphFrontEnd/pull/260

tested by: https://github.com/SpiNNakerManchester/IntegrationTests/pull/238