search

SpiNNakerManchester / SpiNNFrontEndCommon

Common support code for user-facing front end systems.
Apache License 2.0
12 stars 11 forks source link

No time callbacks #1116

Closed Christian-B closed 1 year ago

Christian-B commented 1 year ago

Simpler alternative to https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/1114 et al

The LiveEventConnection has two different even callback methods.

They take different parameters and without this PR this works by usage not by implementation

Based on idea from https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/1062

Only the rarer used callback where the data has no time has been changed.

Safety is added by logging if a handler has no callback.

Must be done at the same time as: https://github.com/SpiNNakerManchester/sPyNNaker/pull/1389

tested by: https://github.com/SpiNNakerManchester/IntegrationTests/pull/239

coveralls commented 1 year ago

Coverage Status

coverage: 42.251% (-0.04%) from 42.293% when pulling 0ee31959aaeba9e3e62651acb4c1862f38b30d82 on no_time_callbacks into 83f03178231791c4ab4b701d335a5c5ce55cdda6 on master.