search

SpiNNakerManchester / SpiNNFrontEndCommon

Common support code for user-facing front end systems.
Apache License 2.0
12 stars 11 forks source link

Live tweaks #1163

Closed rowleya closed 6 months ago

rowleya commented 7 months ago

Fixes to make live output work with Machine vertices

coveralls commented 7 months ago

Coverage Status

coverage: 47.983% (+0.01%) from 47.973% when pulling 68bd7973681cf8a0a9bf0a784825265c2dfc3c16 on live_tweaks into 38b76af70b07514da4558a5a75ddd219d3db3a80 on master.

rowleya commented 7 months ago

It seems like the wrong fix was being done here. This has been corrected. The code that already existed already looked for LPG Machine vertices that had been added through the GFE, so the extra here previously was unnecessary. The FEC code has been updated to account for the fact that no machine vertices should be added through the FECDataView in any case. The other changes are still relevant and help with a few issues though.