Split run methods into smaller blocks of code. - Githubissues

SpiNNakerManchester / SpiNNFrontEndCommon

Common support code for user-facing front end systems.

Apache License 2.0

12 stars 11 forks source link

Split run methods into smaller blocks of code. #1232

Open Christian-B opened 3 weeks ago

Christian-B commented 3 weeks ago

ref: The run methods have grown to be too long and complex

https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/blob/2855f419f28cab9e6f074ee376bc07186be51e74/spinn_front_end_common/interface/abstract_spinnaker_base.py#L538 https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/blob/2855f419f28cab9e6f074ee376bc07186be51e74/spinn_front_end_common/interface/interface_functions/application_runner.py#L74

A better approach is to split these into three different methods for each run type

run timed probably also run timed looped
run forever
run until stopped

the have these call support methods where they share behaviour