SpiNNakerManchester / SpiNNMachine

A python module which contains a representation of the SpiNNaker Machine
Apache License 2.0
4 stars 3 forks source link

Support a Version with more than One none user core #231

Closed Christian-B closed 6 months ago

Christian-B commented 10 months ago

Either we allow Spin2 to define more than 1 n_non_user_cores Then we need this PR

Or we dont and then should remove that call from version

coveralls commented 10 months ago

Coverage Status

coverage: 93.747% (+0.04%) from 93.708% when pulling 9b9d46a2953732be4ee41af0099733737c412f92 on not_monitor into ecc3ae3eab5810295920573416d5cbf7bb15baab on master.

rowleya commented 9 months ago

I don't forsee this being needed, but happy to leave it just in case!

Christian-B commented 9 months ago

We need to decide if we will or will not support more than one none user core.

There is also a higher order question. On the Spin 2 boards will the none user core always be core 0?

rowleya commented 9 months ago

I don't see a need for more than one non-user core so far.

In terms of virtual core support, for SpiNNaker 2 this will likely have to be done host-side, as writing to core memory and starting a core is likely to be direct rather than via SCAMP. This means that we can still have virtual core 0 for SCAMP, but mapped on the host side. Note also that the current plan is to use the special peripheral processor (an additional process on SpiNNaker 2 that is currently guaranteed to exist) for SCAMP, so the real address of the SCAMP processor will always be the same.

Christian-B commented 6 months ago

https://github.com/SpiNNakerManchester/SpiNNMachine/pull/237 does a better job so if that goes in close this one.

Christian-B commented 6 months ago

other pr merged so this not needed.