search

SpiNNakerManchester / SpiNNMan

Interface to SpiNNaker boards from Python
Apache License 2.0
5 stars 1 forks source link

Transceiver is never used as a ContextManager #352

Closed Christian-B closed 11 months ago

Christian-B commented 1 year ago

While the Transceiver does have a close method it is not designed to be used in the With context

as in with Transceiver(..) as txr:

So I suggested it is no loner declared as a superclass of AbstractContextManager

tested by https://github.com/SpiNNakerManchester/IntegrationTests/pull/241

Christian-B commented 1 year ago

spinnaker/SpiNNMan/unittests/test_transceiver.py test_create_new_transceiver_from_list_connections uses with

coveralls commented 1 year ago

Coverage Status

coverage: 50.367% (-0.005%) from 50.372% when pulling a972db457915b70d98991afae3ff4de0bae48e39 on Transceiver_not_a_ContextManager into 5669a2ac1acf8829a80c4b246dfdc69ba26e2305 on master.