search

SpiNNakerManchester / SpiNNMan

Interface to SpiNNaker boards from Python
Apache License 2.0
5 stars 1 forks source link

Version fix #353

Closed Christian-B closed 1 year ago

Christian-B commented 1 year ago

The test board spinn-4.cs.man.ac.uk was down which allowed some bugs to creep in. This because the test where skipped

Before approving this PR please restart spinn-4.cs.man.ac.uk and rerun the tests

  1. BoardTestConfiguration changed from using a cfg file to a trial and error method

    • Will try a 4 Chip board first than spinn-4.cs.man.ac.uk and then 192.168.240.1
    • (minus) This will make the unit test take longer 45s instead of 19s if all three options are not pingable
    • (plus) Automatically uses three different options so more likely to run the tests rather than skipping
    • Can still be changed locally but by editing board_test_configuration.py rather than board_test_configuration.cfg

  2. BoardTestConfiguration now set cfg Machine/version so unittest_setup() needs to be called first

  3. Transceiver unittest use some private properties as they are testing/ using things not required by the normal runs. Alternatives are:

  4. Add api methods just for testing

  5. Remove the Tests

Depends on: https://github.com/SpiNNakerManchester/SpiNNMachine/pull/218 https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/1098 tested by: https://github.com/SpiNNakerManchester/IntegrationTests/pull/223

Christian-B commented 1 year ago

blocker if spinn-4.cs.man.ac.uk is on