search

SpiNNakerManchester / SpiNNMan

Interface to SpiNNaker boards from Python
Apache License 2.0
5 stars 1 forks source link

simplify the spalloc keep alive #401

Closed Christian-B closed 4 months ago

Christian-B commented 4 months ago

The current keep alive cause errors in windows.

This pr simplifies it to use simple threads.

  1. A job when creates starts its own keepalive without being asked to
  2. The keepalive is a simple thread started by the init
  3. The job's destroy method will unset the keepalive url which is the flag for the thread to stop

added a script to get job with a triad.

Must be done at the same time as: https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/1187 https://github.com/SpiNNakerManchester/sPyNNaker/pull/1453

tested by: https://github.com/SpiNNakerManchester/microcircuit_model/pull/38 https://github.com/SpiNNakerManchester/IntegrationTests/pull/275

Christian-B commented 4 months ago

fixes: https://github.com/SpiNNakerManchester/SpiNNMan/issues/402

coveralls commented 4 months ago

Coverage Status

coverage: 59.03% (+0.03%) from 58.998% when pulling 6a20a4f3b9b9eb4dc6b7007b10b12dd0c7391b3c on keep_alive into cdfc5e40fbced5be33f0c8dff7d3f83d38943bad on master.