SpiNNakerManchester / SpiNNUtils

Utility classes and functions for SpiNNaker projects
Apache License 2.0
1 stars 5 forks source link

View holds requires #193

Closed Christian-B closed 2 years ago

Christian-B commented 2 years ago

the flags requires_data_generation and requires_mapping where held in many places (vertices, partitions ect) yet if even a single one was True the Mapping or Data Generation has to be redone. Then all the flags had to be reset.

Instead there is now a single flag for each held in the View. They can be set to True using the View Are automatically set back to False at the end of a run.

The flags are True before the first run so will be true if is_ran_ever() is False

vertices_or_edges_added is now part of requires_mapping AbstractChangableAfterRun no longer needed to identify what may hold these flags

mark_no_changes has been removed or for Population replaced with _reset_has_read_neuron_parameters_this_run

Must be done at the same time as: https://github.com/SpiNNakerManchester/PACMAN/pull/462 https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/973 https://github.com/SpiNNakerManchester/sPyNNaker/pull/1217 https://github.com/SpiNNakerManchester/SpiNNGym/pull/49

tested by https://github.com/SpiNNakerManchester/IntegrationTests/pull/133