Closed Christian-B closed 1 year ago
AbstractContextManager is used but not as expected.
The only class that overrides _context_entered (SQLiteDB) also overrides exist. So in SQLiteDB enter and exit are now implemented directly
No class overirdes _context_exception_occurred so this method makes no sense.
Keeping a simplified AbstractContextManager is needed as Spalloc pass these around and there is not better definition / Abstract
Must be done after https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/1130
related work can be done before or after https://github.com/SpiNNakerManchester/SpiNNMan/pull/368 https://github.com/SpiNNakerManchester/spalloc/pull/88
AbstractContextManager is used but not as expected.
The only class that overrides _context_entered (SQLiteDB) also overrides exist. So in SQLiteDB enter and exit are now implemented directly
No class overirdes _context_exception_occurred so this method makes no sense.
Keeping a simplified AbstractContextManager is needed as Spalloc pass these around and there is not better definition / Abstract
Must be done after https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/1130
related work can be done before or after https://github.com/SpiNNakerManchester/SpiNNMan/pull/368 https://github.com/SpiNNakerManchester/spalloc/pull/88