search

SpiNNakerManchester / SupportScripts

Development scripts for the SpiNNaker project
Apache License 2.0
0 stars 2 forks source link

Incorrect Order in Automatic make. #14

Closed Christian-B closed 5 years ago

Christian-B commented 6 years ago

Reported by @lplana (Thanks)

automatic_make.sh

In the section sPyNNaker/neural_modelling/ source $PWD/setup is after the make

Is this correct?

rowleya commented 6 years ago

This does seem a bit odd... I would expect the setup to be called first. That said, maybe the environment variable the script sets is only needed by other things? This script is in no way mine (I prefer to do these things manually), so maybe @alan-stokes has an opinion?

alan-stokes commented 6 years ago

ermmm......... given that script was built originally to a make file setup that I think has been changed many times over the years...... it might have been needed at one point to be that way for some reason.

but if its causing confusion now, and has no harm being switched, I've got absolutely no issues to switch them around. As long as we have a compiler script, that works in the end.

to add more confusion, if its done afterwards, and the only thing after spynnaker is gfe. which should not have any dependencies on spynnaker at all......... could the spynnaker source setup be removed completely?

I guess this is a legacy from when spynnaker was spynnaker7 and we had the external devices module that was separate, as that would have dependencies on spynnaker/spynnaker7/spynnaker8.

so unless it causes issues, id remove the line completely. anyhow, thats my 2 pence.

andrewgait commented 6 years ago

All that script is currently does is set the NEURAL_MODELLING_DIRS variable, and given that the current installation instructions tell the user to do this before going on to manual make or automatic_make, we should probably take it out.

In addition, sourcing the setup file in spinnaker_tools in this automatic_make script is also probably unnecessary for similar reasons - the user has already set the necessary environment variables themselves by this point.

alan-stokes commented 6 years ago

it might be that we did'nt ask users to set environment variables when we first stated, and so you had to source setup each time....... OHHH, no, it was coz i refused to install it to begin with (as pycharm is happy running stuff without installs), and so i did not have the environment variables, and so i put the source setup to get them. lol. well im preitty sure ive lost that battle years ago. so remove

Christian-B commented 5 years ago

fixed straight to master