error in compiling with automatic_make.sh

[ChiaraBartolozzi]

Hi,

I have updated all my git repositories, after running setup.py in each repo, I tried to run SupportScript/automatic_make.sh and I get two errors:

/Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c: In function ‘initialise_recording’: /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:275:25: προειδοποίηση: initialization from incompatible pointer type [-Wincompatible-pointer-types] address_t address = data_specification_get_data_address(); ^~~~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:279:31: προειδοποίηση: passing argument 2 of ‘data_specification_get_region’ from incompatible pointer type [-Wincompatible-pointer-types] SPIKE_HISTORY_REGION, address); ^~~ In file included from /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:10:0: /Users/chiara/Dev/Libs/SpiNNaker/spinnaker_tools/include/data_specification.h:55:21: σημείωση: expected ‘data_specification_metadata_t {aka struct data_specification_metadata_t }’ but argument is of type ‘address_t {aka long unsigned int }’ static inline void data_specification_get_region( ^~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c: In function ‘initialize’: /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:299:25: προειδοποίηση: initialization from incompatible pointer type [-Wincompatible-pointer-types] address_t address = data_specification_get_data_address(); ^~~~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:302:41: προειδοποίηση: passing argument 1 of ‘data_specification_read_header’ from incompatible pointer type [-Wincompatible-pointer-types] if (!data_specification_read_header(address)) { ^~~ In file included from /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:10:0: /Users/chiara/Dev/Libs/SpiNNaker/spinnaker_tools/include/data_specification.h:49:6: σημείωση: expected ‘data_specification_metadata_t {aka struct data_specification_metadata_t }’ but argument is of type ‘address_t {aka long unsigned int }’ bool data_specification_read_header(data_specification_metadata_t ds_regions); ^~~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:308:51: προειδοποίηση: passing argument 2 of ‘data_specification_get_region’ from incompatible pointer type [-Wincompatible-pointer-types] data_specification_get_region(SYSTEM, address), ^~~ In file included from /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:10:0: /Users/chiara/Dev/Libs/SpiNNaker/spinnaker_tools/include/data_specification.h:55:21: σημείωση: expected ‘data_specification_metadata_t {aka struct data_specification_metadata_t }’ but argument is of type ‘address_t {aka long unsigned int }’ static inline void data_specification_get_region( ^~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:307:10: σφάλμα: too few arguments to function ‘simulation_initialise’ if (!simulation_initialise( ^~~~~ In file included from /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:14:0: /Users/chiara/Dev/Libs/SpiNNaker/spinnaker_tools/include/simulation.h:99:6: σημείωση: declared here bool simulation_initialise( ^~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:314:58: προειδοποίηση: passing argument 2 of ‘data_specification_get_region’ from incompatible pointer type [-Wincompatible-pointer-types] data_specification_get_region(PROVENANCE_REGION, address)); ^~~ In file included from /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:10:0: /Users/chiara/Dev/Libs/SpiNNaker/spinnaker_tools/include/data_specification.h:55:21: σημείωση: expected ‘data_specification_metadata_t {aka struct data_specification_metadata_t }’ but argument is of type ‘address_t {aka long unsigned int }’ static inline void data_specification_get_region( ^~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:323:59: προειδοποίηση: passing argument 2 of ‘data_specification_get_region’ from incompatible pointer type [-Wincompatible-pointer-types] data_specification_get_region(POISSON_PARAMS, address))) { ^~~ In file included from /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:10:0: /Users/chiara/Dev/Libs/SpiNNaker/spinnaker_tools/include/data_specification.h:55:21: σημείωση: expected ‘data_specification_metadata_t {aka struct data_specification_metadata_t }’ but argument is of type ‘address_t {aka long unsigned int }’ static inline void data_specification_get_region( ^~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:328:59: προειδοποίηση: passing argument 2 of ‘data_specification_get_region’ from incompatible pointer type [-Wincompatible-pointer-types] data_specification_get_region(POISSON_PARAMS, address))) { ^~~ In file included from /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:10:0: /Users/chiara/Dev/Libs/SpiNNaker/spinnaker_tools/include/data_specification.h:55:21: σημείωση: expected ‘data_specification_metadata_t {aka struct data_specification_metadata_t }’ but argument is of type ‘address_t {aka long unsigned int }’ static inline void data_specification_get_region( ^~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c: In function ‘resume_callback’: /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:360:25: προειδοποίηση: initialization from incompatible pointer type [-Wincompatible-pointer-types] address_t address = data_specification_get_data_address(); ^~~~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:363:59: προειδοποίηση: passing argument 2 of ‘data_specification_get_region’ from incompatible pointer type [-Wincompatible-pointer-types] data_specification_get_region(POISSON_PARAMS, address))){ ^~~ In file included from /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:10:0: /Users/chiara/Dev/Libs/SpiNNaker/spinnaker_tools/include/data_specification.h:55:21: σημείωση: expected ‘data_specification_metadata_t {aka struct data_specification_metadata_t }’ but argument is of type ‘address_t {aka long unsigned int }’ static inline void data_specification_get_region( ^~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c: In function ‘store_poisson_parameters’: /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:391:25: προειδοποίηση: initialization from incompatible pointer type [-Wincompatible-pointer-types] address_t address = data_specification_get_data_address(); ^~~~~~~~~~~ /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:392:61: προειδοποίηση: passing argument 2 of ‘data_specification_get_region’ from incompatible pointer type [-Wincompatible-pointer-types] address = data_specification_get_region(POISSON_PARAMS, address); ^~~ In file included from /Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/modified_src/spike_source/poisson/spike_source_poisson.c:10:0: /Users/chiara/Dev/Libs/SpiNNaker/spinnaker_tools/include/data_specification.h:55:21: σημείωση: expected ‘data_specification_metadata_t {aka struct data_specification_metadata_t }’ but argument is of type ‘address_t {aka long unsigned int }’ static inline void data_specification_get_region( ^~~~~~~~~ make[1]: [/Users/chiara/Dev/Libs/SpiNNaker/sPyNNaker/neural_modelling/builds/spike_source_poisson/spike_source/poisson/spike_source_poisson.o] Error 1 make: [all] Error 2

I am running on MAC OS, Mojave.

[dkfellows]

Looks like there are old versions of the SpiNNFrontEndCommon C headers in the spinnaker_tools include directory.

[alan-stokes]

has this been resolved???

[Christian-B]

Not resolved. Discussed with @dkfellows. There are many sticky plaster options but the cleanest he wants to do is Stop using /SpiNNakerManchester/spinnaker_tools as an install directory.

IE having SPINN_DIRS point somewhere else and have spinnaker_tools install there too!

[rowleya]

There is no reason why this should not be done. We need to define SPINN_DIRS but installing everything there including spinnaker_tools should work well. Note though that this will still result in errors in mismatched files if this directory is not cleaned before installing other dependencies, but the advantage is that cleaning this folder is as easy as removing and recreating it.

[dkfellows]

Stopping mixing things together inside repositories will help a lot.

On my machine, I was aware of the problems ahead of time (natural suspicion of others' makefiles FTW!) so I have a directory (that I happen to put as a sibling to my checkouts of everything and that I happen to call spinnlibs — neither are requirements) which I hand-copied things out of spinnaker_tools into and which I have SPINN_DIRS point to.

[dkfellows]

With the PR accepted, we'll still need to update the installation instructions.