SpiNNakerManchester / SupportScripts

Development scripts for the SpiNNaker project
Apache License 2.0
0 stars 2 forks source link

gitclone.sh does not work if master and a tag point to the same commit #32

Closed Christian-B closed 3 years ago

Christian-B commented 3 years ago

Discovered during the 6.0.0 release.

The way gitclone.sh works fails if there is a release (or maybe even just a tag) which points to the same commit as master/main

To replicate this bug create a release (or maybe even just a tag) of master (or a branch which is neither ahead of behind master) on one of the other repositories and then run gitclone.hs on that repository

Workaround is to always make sure that master/main on all repositories does not point to the same commit as a release.

Christian-B commented 3 years ago

Error was: Cloning into 'spinnaker_tools'... fatal: Remote branch refs/tags/Spinnaker6.0.0 not found in upstream origin script returned exit code 128

yet got tag does list it

Christian-B commented 3 years ago

I have noticed that the issue is not just when master == the tag.

It is generally due to trying to clone the tag.

For example SpinnMan tag/6.0.0 action fails because: Could not find remote branch refs/tags/6.0.0 to clone.