search

SpiNNakerManchester / sPyNNaker

The SpiNNaker implementation of the PyNN neural networking language
Apache License 2.0
105 stars 44 forks source link

better handling of cfg delay_support_adder = None #1192

Open Christian-B opened 2 years ago

Christian-B commented 2 years ago

It is possible to turn off the DelaySupportAdder by setting [Mapping] delay_support_adder = None

spinn_gym does this.

yet this raises the following issues / concerns.

  1. Currently spinn gym has to override AbstractAcceptsIncomingSynapses.verify_splitter because it expects a AbstractSpynnakerSplitterDelay and SplitterOneAppOneMachine is not one

  2. Users can enter a delay which is too big and no error or warning -for example take IntroLab/learning/simple.py add a cfg which turns with delay_support_adder = None increase the delay to 20 and the simtime to 40 No spike, no warning!

rowleya commented 2 years ago

Seems a bit hacky... I would think that it should just have a splitter that says it can't accept delays?