This lets the spalloc protocol pass simple exception information from the server to the client, so that problems that the client (or perhaps the code that calls it) could potentially do something about can actually find out what happened. The changes here on the client side just detect those “kind” failures and convert them to a SpallocServerException with the message out of the payload. Correct code won't see them, but mildly erroneous code will now get a sane explanation (instead of needing someone to look in the spalloc server log and guess what went wrong and when).
Coverage decreased (-1.0%) to 99.006% when pulling b9c7f607da66c4e9d3edb8e6c6f646509458e7a5 on protocol-change into d4dc468b82ec41c2c29e5d7ddf66f688ae5456aa on master.
Coverage decreased (-1.0%) to 99.005% when pulling 5e1192d3ab55e32ff6abe6db667b28ff5920f145 on protocol-change into d4dc468b82ec41c2c29e5d7ddf66f688ae5456aa on master.
Coverage decreased (-1.0%) to 99.008% when pulling 4ae519300bab4014577bd6d94930c2ed690cfcfd on protocol-change into eecc42950f5ac6d690fee58da06df28fd1b20e55 on master.
Coverage decreased (-1.0%) to 99.008% when pulling 1bed16f36880421792404a910018cd17394cd9b5 on protocol-change into eecc42950f5ac6d690fee58da06df28fd1b20e55 on master.
Coverage decreased (-0.2%) to 99.828% when pulling a2c6d9b4ccd32273f0514d7c3886d26bdfe84c6e on protocol-change into 7b0c60b2c138c317fde9aa8759c4ca71b26acb4d on master.
Coverage remained the same at 100.0% when pulling ce932b194209c416a8638d8cbd668a80068b0475 on protocol-change into 7b0c60b2c138c317fde9aa8759c4ca71b26acb4d on master.
Coverage decreased (-0.4%) to 99.578% when pulling 689b894c1fca7be056715f827b725f6f99513cba on protocol-change into 7b0c60b2c138c317fde9aa8759c4ca71b26acb4d on master.
Coverage decreased (-0.08%) to 99.915% when pulling 1f69695031592f02bb5fac5423b1ed971a2c00fa on protocol-change into 7b0c60b2c138c317fde9aa8759c4ca71b26acb4d on master.
Coverage decreased (-0.08%) to 99.915% when pulling 1f69695031592f02bb5fac5423b1ed971a2c00fa on protocol-change into 7b0c60b2c138c317fde9aa8759c4ca71b26acb4d on master.
Coverage decreased (-0.08%) to 99.915% when pulling 1f69695031592f02bb5fac5423b1ed971a2c00fa on protocol-change into 7b0c60b2c138c317fde9aa8759c4ca71b26acb4d on master.
This lets the spalloc protocol pass simple exception information from the server to the client, so that problems that the client (or perhaps the code that calls it) could potentially do something about can actually find out what happened. The changes here on the client side just detect those “kind” failures and convert them to a
SpallocServerException
with the message out of the payload. Correct code won't see them, but mildly erroneous code will now get a sane explanation (instead of needing someone to look in the spalloc server log and guess what went wrong and when).