search

Spice-King / foundry-swnr

Stars Without Number: Revised for Foundry VTT
GNU Affero General Public License v3.0
30 stars 43 forks source link

Added launch.json and tasks.json file so that you gitignore. #3

Closed RubberRobot closed 4 years ago

RubberRobot commented 4 years ago

Made it a bit easier to get started debugging. This should let you build and run the application through VSCodes debug menu or by hitting F5. You should be able to hit breakpoints in VSCode. I also added the default data directory to the .gitignore file.

bwebster4 commented 4 years ago

This is proving very helpful :slightly_smiling_face:

Spice-King commented 4 years ago

I'm going to reject this for a few reasons.

First is that it's three clearly separate commits/tasks rolled up into one, though a housekeeping commit which goes around an reformatted the whole project to unify things like indenting, line endings, or spacing would be acceptable.

Second, I had committed, but not pushed the .gitignore change already. Habit from work since I like to rewrite my history at times to fix bad wording, reorder edits or add forgotten related changes. (Big front end rewrite at work)

Third, the launch.json file is too variable to be committed. Not everyone uses Chrome, plus not everyone has their Foundry develop instance on the default port.

Forth, the tasks.json just duplicates the contents of package.json scripts. It's a second place to need to fix if changes are made to the scripts. The NPM plugin provides quick enough access all scripts via the side bar or the action npm: Run Script.