Closed ToddThomson closed 3 years ago
Take a look at: https://github.com/SpiceSharp/SpiceSharpParser/blob/master/src/SpiceSharpParser/SpiceParserResult.cs
There are 3 properties: 2 with models (before preprocessing and after) and 1 with SpiceSharp model.
I'm open for any suggestions how to make it better :)
@marcin-golebiowski Yes, I was reviewing the SpiceParserResult class. There is no issue with the properties themselves. I just thought the property name SpiceSharpModel should not contain your implementation specifics (SpiceSharp) and that the property Type was not accurately named ( a result within a result, but what is actually returned is a SpiceModel ). This is just my opinion/input. Thanks Marcin!
Please review #146
I think it's small step in right direction. I think there should be additional layer of abstraction before creating instances of Spice# library. For example there should be generic Resistor class etc.
What do you think?
ETA for this layer of abstraction: second week of 2020.
@marcin-golebiowski Yes to Generics, Interfaces ( and async methods ).
I haven't got to the point of running circuit simulations, but my gut feel is that the API should be async.
Let me think about it. I like the idea :)
Changed by #152. I've simplified the naming and types.
Feel free to reopen the ticket if you disagree with the work.
The
SpiceParserResult
returned fromParser.ParseNetlist()
returns the property:SpiceSharpModel
of TypeSpiceNetlistReaderResult
. Perhaps the naming here could be improved.SpiceSharpModel
is accurate, but does not need to contain your Spice flavour (sorry). Perhaps you could renameSpiceNetlistReaderResult
toSpiceModel
, as that is what it is, and then rename the property toSpiceModel
.