search

Spico197 / DocEE

🕹️ A toolkit for document-level event extraction, containing some SOTA model implementations.
https://doc-ee.readthedocs.io/
MIT License
234 stars 36 forks source link

Potential performance issue: plotting slow in matplotlib == 3.3.0 #85

Closed HarryCollins2 closed 8 months ago

HarryCollins2 commented 8 months ago

Description

Hello. I have discovered a performance degradation in the plot function of matplotlib version 3.3.0. And I notice the repo depends on pandas 3.3.0 in requirements.txt. I am not sure whether this performance problem in matplotlib will affect this repository. I found some discussions on matplotlib GitHub related to this issue, including https://github.com/matplotlib/matplotlib/issues/18743.

Suggestion

I would recommend considering an version change to matplotlib >= 3.3.3 or <3.3.0(e.g. 3.2.2) or exploring other solutions to optimize the performance of plotting.

Spico197 commented 8 months ago

Thanks for the information~ Since the fig plotting function is called on offline mode, it does not affect the training and inference speed or performance here. Feel free to upgrade matplotlib to the latest version~