search

SpicyChair / pluvia_weather_flutter

Pluvia 🌦️ | A weather app with beautiful animations, built with Flutter.
GNU General Public License v3.0
149 stars 17 forks source link

Missing translations for weekdays #45

Open GanovenEde opened 2 years ago

GanovenEde commented 2 years ago

Hello. Great app, I'm using it for months now.

But there is one thing that bothers me a little: weekdays are shown in English (Mon, Tue, Wed, ...) even if another language has been selected.

Would it be possible to fix this?

Thank you.

SpicyChair commented 2 years ago

Translating and abbreviating the weekdays from other languages might be a bit difficult - would something like a "day number" work better? As in, MON -> 1?

GanovenEde commented 2 years ago

Maybe this document helps: https://www.ema.europa.eu/en/documents/other/abbreviation-names-days-calendarised-blisters_en.pdf

Using numbers would cause confusion, I guess.

acuz commented 2 years ago

Hi @SpicyChair , would changing line 65 of the file daily_cart.dart in this way work? Now: "${weekDay.substring(0, 3).toUpperCase()}", Correction: "${Language.getTranslation(weekDay.substring(0, 3)).toUpperCase()}",

Of course Language.get should point to the keys in localization.dart. I can help with the implementation for each language in localization.dart using the link by @GanovenEde. If we don't know the translation for some language we can leave it in English.

GanovenEde commented 2 years ago

Hi! Would be happy to see any progress here. Incompletely localized apps often make a suspicious impression.