search

SpicyChair / pluvia_weather_flutter

Pluvia 🌦️ | A weather app with beautiful animations, built with Flutter.
GNU General Public License v3.0
149 stars 17 forks source link

GMS in F-Droid build #55

Open linsui opened 2 years ago

linsui commented 2 years ago

~geolocator pulls in GMS, see https://github.com/Baseflow/flutter-geolocator/blob/28c8657b370abe1caf93c24b382d4dce5b5c460f/geolocator_android/android/build.gradle#L45. You can use https://gitlab.com/hanntech-gmbh/free2pass/flutter-geolocator-floss instead.~ ~The geolocator-floss is already used... Then the nonfree libs may com from somewhere else.~ It's not used anymore. So that's the problem. Could you please take a look? Thanks!

2022-07-13 11:19:13,698 DEBUG: > /opt/android-sdk/build-tools/31.0.0/dexdump /tmp/tmpdmptos5k/classes.dex
2022-07-13 11:19:14,386 DEBUG: Found class 'com/google/android/gms/auth/api/signin/GoogleSignInAccount'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/location/LocationRequest'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/common/api/internal/b'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/common/api/internal/BasePendingResult'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/location/a'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/common/api/internal/c'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/common/api/b'
2022-07-13 11:19:14,388 DEBUG: Found class 'com/google/android/gms/common/api/a'
2022-07-13 11:19:14,388 DEBUG: Found class 'com/google/android/gms/common/api/Scope'
2022-07-13 11:19:14,388 DEBUG: Found class 'com/google/android/gms/auth/api/signin/a'
2022-07-13 11:19:14,388 DEBUG: Found class 'com/google/android/gms/dynamite/DynamiteModule'
2022-07-13 11:19:14,389 DEBUG: Found class 'com/google/android/gms/common/annotation/KeepName'
2022-07-13 11:19:14,389 DEBUG: Found class 'com/google/android/gms/common/api/internal/LifecycleCallback'
2022-07-13 11:19:14,389 DEBUG: Found class 'com/google/android/gms/common/api/GoogleApiActivity'
2022-07-13 11:19:14,389 DEBUG: Found class 'com/google/android/gms/common/util/DynamiteApi'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/location/LocationAvailability'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/common/internal/ReflectedParcelable'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/common/api/Status'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/location/b'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/location/c'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/location/LocationResult'
2022-07-13 11:19:14,391 DEBUG: Found class 'com/google/android/gms/common/api/internal/a'
SpicyChair commented 2 years ago

Hmm. That's odd - I can't find any mentions of GMS in the source. I'll keep investigating, thanks for bringing this up.

linsui commented 2 years ago

Mapbox may also pulls in GMS.

SpicyChair commented 2 years ago

I'm not sure when or why I removed the FLOSS geolocator import... It's back now.

It should be fixed now.

linsui commented 2 years ago 
2022-08-06 13:53:36,799 DEBUG: Found class 'com/google/android/gms/common/annotation/KeepName'
2022-08-06 13:53:36,799 DEBUG: Found class 'com/google/android/gms/dynamite/DynamiteModule'
2022-08-06 13:53:36,799 DEBUG: Found class 'com/google/android/gms/auth/api/signin/GoogleSignInAccount'
2022-08-06 13:53:36,800 DEBUG: Found class 'com/google/android/gms/location/c'
2022-08-06 13:53:36,800 DEBUG: Found class 'com/google/android/gms/common/api/internal/a'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/location/a'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/common/internal/ReflectedParcelable'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/common/api/internal/BasePendingResult'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/location/b'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/common/api/Scope'
2022-08-06 13:53:36,802 DEBUG: Found class 'com/google/android/gms/common/api/internal/LifecycleCallback'
2022-08-06 13:53:36,802 DEBUG: Found class 'com/google/android/gms/common/api/b'
2022-08-06 13:53:36,802 DEBUG: Found class 'com/google/android/gms/common/api/Status'
2022-08-06 13:53:36,802 DEBUG: Found class 'com/google/android/gms/location/LocationRequest'
2022-08-06 13:53:36,803 DEBUG: Found class 'com/google/android/gms/common/util/DynamiteApi'
2022-08-06 13:53:36,803 DEBUG: Found class 'com/google/android/gms/common/api/internal/b'
2022-08-06 13:53:36,803 DEBUG: Found class 'com/google/android/gms/location/LocationAvailability'
2022-08-06 13:53:36,804 DEBUG: Found class 'com/google/android/gms/common/api/internal/c'
2022-08-06 13:53:36,804 DEBUG: Found class 'com/google/android/gms/location/LocationResult'
2022-08-06 13:53:36,804 DEBUG: Found class 'com/google/android/gms/auth/api/signin/a'
2022-08-06 13:53:36,804 DEBUG: Found class 'com/google/android/gms/common/api/GoogleApiActivity'
2022-08-06 13:53:36,805 DEBUG: Found class 'com/google/android/gms/common/api/a'

The classes is still in the apk. Not sure if they are from the mapbox.