Block QQGameHall in UA - Githubissues

SpiderLabs / owasp-modsecurity-crs

OWASP ModSecurity Core Rule Set (CRS) Project (Official Repository)

https://modsecurity.org/crs

Apache License 2.0

2.44k stars 725 forks source link

Block QQGameHall in UA #1730

Closed theMiddleBlue closed 4 years ago

theMiddleBlue commented 4 years ago

we should add QQGameHall to 913100 (scanners-user-agents.data). Unfortunately that's not a "scanner" but we have not a different category yet... What do you think about it?

(thanks Daniel Stenberg @bagder)

bagder commented 4 years ago

I've blocked "QQGameHall" from the curl site from where the above screenshot comes from. That's the full user-agent string this thing uses. Still weird since it is supposedly the name of a game launcher...

dune73 commented 4 years ago

I'd be happy to merge anytime, @theMiddleBlue.

theMiddleBlue commented 4 years ago

thanks @dune73 and @bagder, I'm going to open a PR.

dune73 commented 4 years ago

Closing this in favor of PR #1731, which was been merged.