Spideroak rebranding 2015

[devgeeks]

This is the rebranding for 3.4.0

Includes icon changes as well as the displayName and shortDisplayName hook changes

• [x]  General Comment
• <img border=0 src='https://avatars.githubusercontent.com/u/515685?v=3' height=16 width=16'> The code looks good, but when I build Blue (groups) the installed dev app - on an Android emulator, running 4.4.4, and my Nexus 5 running 5.1 and Nexus 7 running 5.1.1 - at least the login screen has problematic colors: the login screen background and text seem both to be white. Rendering of Orange (One) and Black, however, both seem fine. Perhaps there's something wrong with my build env, but not sure what to check, and seems necessary to determine before granting the pull.
• <img border=0 src='https://avatars.githubusercontent.com/u/554999?v=3' height=16 width=16'> OK. This should be ready now.
• [x]  File: src/app.js:L335-345
• <img border=0 src='https://avatars.githubusercontent.com/u/515685?v=3' height=16 width=16'> Need a condition for window.device being undefined, eg in the case of desktop browser. So:

  if ($.os.android && window.device && parseFloat(window.device.version) >= 5.0) {

• [x]  File: .cordova/hooks/after_prepare/version.js:L42-58
• <img border=0 src='https://avatars.githubusercontent.com/u/515685?v=3' height=16 width=16'> Might make the code a little cleaner to do a "configFile = require(projectConfigFilePath)" rather than repeating the latter several times.

  

[kenmanheimer]

The code looks good, but when I build Blue (groups) the installed dev app - on an Android emulator, running 4.4.4, and my Nexus 5 running 5.1 and Nexus 7 running 5.1.1 [problem also happening in desktop browser] - at least the login screen has problematic colors: the login screen background and text seem both to be white.

Rendering of Orange (One) and Black, however, both seem fine.

Perhaps there's something wrong with my build env, but not sure what to check, and seems necessary to determine before granting the pull.

[devgeeks]

OK. This should be ready now.