search

SpiderStrategies / kalpa-tree

A tree implementation backed by D3
http://spiderstrategies.github.io/kalpa-tree/
ISC License
4 stars 2 forks source link

Nixes hardware acceleration #434

Closed donald-john closed 6 years ago

donald-john commented 6 years ago

This nixes hardware acceleration in order to address https://github.com/SpiderStrategies/Scoreboard/issues/19595

For posterity, an explanation. We're nixing hardware acceleration here because it appears the following issues for which it was introduced are no longer problems.

  1. https://github.com/SpiderStrategies/scoreboard-gantt/issues/67
    • This was re-confirmed a problem w/o hardware acceleration in Safari 10.x but is no longer a problem in Safari 11.x w/o hardware acceleration
  2. https://github.com/SpiderStrategies/Scoreboard/issues/9792
    • This appears to no longer be a problem for Safari 10.x or 11.x without hardware acceleration
  3. https://github.com/SpiderStrategies/Scoreboard/issues/9031
    • This appears to no longer be a problem for Safari 10.x or 11.x without hardware acceleration
  4. https://github.com/SpiderStrategies/Scoreboard/issues/17017
    • This appears to no longer be a problem for Safari 10.x or 11.x without hardware acceleration
nathanbowser commented 6 years ago

Amazing commenting in this PR. Thank you @donald-john. Thanks for also putting up with my stubbornness! 😁

mattsgarlata commented 6 years ago

Thanks for documenting this so carefully, Don!