search

SpiderStrategies / kalpa-tree

A tree implementation backed by D3
http://spiderstrategies.github.io/kalpa-tree/
ISC License
4 stars 2 forks source link

Adds defensive checks when clearing filtered tree results so forest #439

Closed nathanbowser closed 5 years ago

nathanbowser commented 5 years ago

trees without nodes don't cause JS blowups.

For https://github.com/SpiderStrategies/Scoreboard/issues/21602

nathanbowser commented 5 years ago

@mattsgarlata Sorry but I'd like another review. I basically rewrote it based on your comments so it was a bit clearer.

mattsgarlata commented 5 years ago

Nice! I like the new version. +1