search

SpiderStrategies / kalpa-tree

A tree implementation backed by D3
http://spiderstrategies.github.io/kalpa-tree/
ISC License
4 stars 2 forks source link

Removes `moz` styles prefix for firefox #481

Closed nathanbowser closed 4 months ago

nathanbowser commented 4 months ago

Apparently no longer needed (or supported)

For https://github.com/SpiderStrategies/Scoreboard/issues/58126

mattsgarlata commented 4 months ago

Will this break backward compatibility with old versions of Firefox? We aren't required to support old versions, but if it's easy to maintain compatibility with both, that would be nice.

derekstory commented 4 months ago

Confirmed it's working with the most up-to-date FF version.

nathanbowser commented 4 months ago

@derekstory I just found a moz prefix in the css, going to test another commit in a moment.

nathanbowser commented 4 months ago

Will this break backward compatibility with old versions of Firefox? We aren't required to support old versions, but if it's easy to maintain compatibility with both, that would be nice.

@mattsgarlata Good question. I suspect these prefixes aren't needed. They were historically added for experimental features but this stuff is way way way past the experimental days. But I'll check b/c I'm going to make one more change to css.

nathanbowser commented 4 months ago

@mattsgarlata Jerry confirmed < 126 is working

https://spiderstrategies.slack.com/archives/C02N7NPRX/p1716313245948109?thread_ts=1716313176.269269&cid=C02N7NPRX

mattsgarlata commented 4 months ago

Awesome! The code changes look good to me, so feel free to merge these in when ready.