search

SpiderStrategies / node-tweet-stream

Node twitter module to hook into the public filter streaming, seamlessly updating the tracking keywords.
210 stars 43 forks source link

Allow the addFilter commands to accept arrays as input #38

Closed Gurrt closed 8 years ago

Gurrt commented 8 years ago

I noticed that only the keyword tracking had an option to add multiple keywords to filter at once. I abstracted this logic out of the function and applied it to all possible filters.

nathanbowser commented 8 years ago

This feels like a bloated API to me. What do you think about making a tracking function be able to support a single keyword or multiple?

Gurrt commented 8 years ago

You're right, that would be a better solution. See newest commit. While it is now essentially obsolete, I kept the trackMultiple function in there for backwards compatibility. Removed the ones I added in the previous commit though.

nathanbowser commented 8 years ago

Merged manually with some minor changes. Thanks!

nathanbowser commented 8 years ago

@Gurrt + node-tweet-stream@1.10.0 is on npm