Open mvdwalle opened 8 years ago
This seems reasonable to me. Have you been using this branch in your own work?
I'd like to see an opt-in approach to this, though.
e.g.
new Twitter({
consumer_key: '',
consumer_secret: '',
token: '',
token_secret: ''
}, {
gzip: true // defaults to false to prevent any potential breakage.
})
I chanegd the pull request as suggested. This change is one of a few that we are or want to use internally at my company.
Awesome, thanks! I'd say once you write some tests, we can get this merged.
Any news? Is this still supported?
Module is supported. Waiting on tests for this PR
Twitter can support gzip compression. I added the option gzip: true to the request and added code to handle either gzip, deflate or none.
I took a quick look at how the tests were set up and I could create tests for this if wanted. But I wanted someone to review first.