SpielefreakJ / VersionControl

Control the versions of the servers in your network [ViaVersion addon]
https://www.spigotmc.org/resources/versioncontrol-viaversion-addon.95878/
GNU General Public License v3.0
0 stars 0 forks source link

Connection Issues with Specific Plugin Versions on Bungeecord Network #1

Open amatheo opened 1 month ago

amatheo commented 1 month ago

I've been using this plugin successfully for some time on my Bungeecord network. However, recently I've encountered an issue when attempting to set it up again with newer versions. The main problem arises when trying to connect using the specified versions within the config file.

Plugin Version: 1.3.4 Bungeecord Version: 1.20-R0.3-SNAPSHOT ViaVersion & ViaBackwards: 4.10.0

Steps to Reproduce

  1. Set up the plugin with the initial configurations.
  2. Modify config.yml to match the new versions as follows
    
    Server:
    Fallback: kick
    vibing:
    minVersion: '735'
    maxVersion: '765'

...

3. Trying to connect with Vanilla Client 1.20.4

### Observed Behavior

Connections cannot be established using the specified version range. Setting the minVersion and maxVersion to -1 does allow connections, but it removes the version restrictions, enabling all versions to connect, which defeats the purpose of the plugin.

### Temporary Fix
Currently, the only workaround is to set the version in config.yml to -1, which is not ideal as it allows any client version to connect:
``` yaml
Server:
  Fallback: kick
  vibing:
    minVersion: '-1'
    maxVersion: '-1'

...

Versions:
  '-1': test

Possible Cause

I suspect that changes in the ViaAPI can be attributed to this issue

SpielefreakJ commented 1 month ago

Thank you for showing this issue to me.

I quickly looked a bit into it, and it seems that currently Viaversion detects every user as playing on version "Unknown (-1)" on bungeecord, on Paper it seems fine. Screenshot from 2024-05-13 22-18-21

Tested some older bungeecord versions (build 1800 from 17 Feb 2024) and it works fine with viaversion, except you get kicked due to an invalid public key.... Screenshot from 2024-05-13 22-32-08

I can look up later if i could do something but right now it seems that Bungee is the problem, as older Viaversion versions on current bundee produce the same problem like above