SpigotMC / BungeeCord

BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers.
https://www.spigotmc.org/go/bungeecord
Other
1.59k stars 1.11k forks source link

Make TabCompleteEvent an AsyncEvent #1857

Open ghost opened 8 years ago

ghost commented 8 years ago

Is there a possibility to make TabeCompleteEvent async, to allow grabbing players online or other information from MySQL/NoSQL databases for servers that implement more than one Bungee.

minecrafter commented 8 years ago

The implementation of AsyncEvent is simply horrible. It doesn't work well with backwards compatibility, for instance.

For that reason, I'm opposed to new AsyncEvents.

ghost commented 8 years ago

ATM I'm canceling the event... Then publishing to redid, where the server will send another tab complete packet to the player... Sort of counterintuitive :P

AlexDicy commented 8 years ago

Quote, having an Async Tab event would be useful

Janmm14 commented 8 years ago

Making the tab event async is a good idea, especially as the issues of the current asyncevent impl are usually not that big for a tabcomplete.

AgentLV commented 8 years ago

I would also love to see the tabcompleteevent become async!