search

SpigotMC / BungeeCord

BungeeCord, the 6th in a generation of server portal suites. Efficiently proxies and maintains connections and transport between multiple Minecraft servers.
https://www.spigotmc.org/go/bungeecord
Other
1.57k stars 1.1k forks source link

[Request] New inject_commands functionality #2569

Open x1p opened 5 years ago

x1p commented 5 years ago

Thank you for solving issue #2568 This solves all bungeecords' internal commands, except /bungee.

However. It is still possible to find commands of other plugins. I could ask every developer of every small or big bungee plugin to respect the permissions and hide every command for which a player does not have te corresponding permission. But this would be a hell of a job.

So I would like to ask you to add a special bungeecord.permission something like bungeecord.tabcomplete to turn this feature on only for those who have this bungeecord permission (as in staff). This would disable smart players looking for possible security issues by all means.

Thanks in advance

md-5 commented 5 years ago

Spigot behaves the same way. Have you had this issue with every spigot plugin you use? If a plugin is not defining permissions then thats a bug in the plugin. It also means that the player can execute that command already, regardless of it shows up in tab complete.

Finally, what would the point in this be? Surely tab completion is much more important to your players than your staff? Seems kind of silly to only allow staff to tab complete, given players are the ones that care when /server shows as red.

x1p commented 5 years ago

Spigot plugins have the same issue. Since 1.13, many plugins have made changes to implement permissions in command suggestions. Additionally, I have a plugin to block all unwanted command suggestions to block plugins which are not updated yet. For bungee there is no plugin to block bungee like commands to my knowledge. This developer would like to know if there is an API for this so he can implement blockage of bungee commands as well?

Tabcomplete for e.g. litebans is important for staff to suggest playernames. So far tabcomplete for litebans commands, especially playernames, do not work since 1.13. If any commands for bungee plugins are used, it is staff which use it. Not players. Although not in my case, and I can't see why I'm so special in this. /server commands are usually replaced by menu's for players to click on.

The only other solution is to write to any plugin I use. I will take action in this, as of many other plugins which already made improvements after remarks. But this will take time and not every plugin will get updated in a reasonable amount of time, if ever.

Last suggestion: is it then perhaps possible to exclude some of the commands of tab completing via the disabled_commands function?